[webview_flutter_android] Adds opt out of displayCutout and systemBars Android inset changes#11192
Open
bparrishMines wants to merge 23 commits intoflutter:mainfrom
Open
[webview_flutter_android] Adds opt out of displayCutout and systemBars Android inset changes#11192bparrishMines wants to merge 23 commits intoflutter:mainfrom
displayCutout and systemBars Android inset changes#11192bparrishMines wants to merge 23 commits intoflutter:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For WebView versions >=144, support has been added for displayCutout() insets and systemBars() insets. This is causing WebViews to incorrectly report that it is obscured by a system bar or display cutout as demonstrated in this issue.
This adds the opt out for inset changes as explained in this chromium doc. It seems Flutter handles safe areas for platform views, so the
WebViewcan zero out inset changes to the View.iOS does something similar. And it also sets UIScrollView.contentInsetAdjustmentBehavior to
Never. My assumption was that this was never done for Android, becauseWebViews didn't receive these inset changes until this version.Code sample
main.dart in
webview_flutter_android:Screenshots
Fixes flutter/flutter#182208
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2